2021-08-31 10:28 (UTC+0800), zhihongx.p...@intel.com: > From: Zhihong Peng <zhihongx.p...@intel.com> > > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be > released alone. > > Fixes: af75078fece3 (first public release) > Cc: sta...@dpdk.org > > Signed-off-by: Zhihong Peng <zhihongx.p...@intel.com> > --- > lib/cmdline/cmdline_socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c > index 998e8ade25..ebd5343754 100644 > --- a/lib/cmdline/cmdline_socket.c > +++ b/lib/cmdline/cmdline_socket.c > @@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl) > return; > > terminal_restore(cl); > + cmdline_free(cl); > }
Now cmdline_free() may not be called after cmdline_stdin_exit(). User code that does so needs to be changed to avoid double-free. This behavior change must be documented in the release notes. I'm not sure it should be backported because of the above.
