2021-08-31 10:01 (UTC-0700), Jie Zhou: > On Sun, Aug 29, 2021 at 01:18:12AM +0300, Dmitry Kozlyuk wrote: > > 2021-08-18 10:13 (UTC-0700), Jie Zhou: > > > In app/test/meson.build > > > - Specify the subset of source files to compile on Windows > > > - Specify the subset of tests to be enabled on Windows > > > Signed-off-by: Jie Zhou <j...@linux.microsoft.com> > > > --- > > > app/test/meson.build | 859 ++++++++++++++++++++++++++----------------- > > > 1 file changed, 515 insertions(+), 344 deletions(-) > > > > Commit messages should explain the reason for the change, > > which itself is precisely described by the diff below. > > For example, why these specific tests are selected? > > > > Please don't create two lists, it will be hard to maintain. > > > Since not all the libraries unit tests depend on are built on Windows yet, > and not all unit tests are ported on Windows yet, what would be a proper way > to have one list but only a subset of the list actually enabled on Windows? > Thanks for any suggestions.
I would put all the common tests to the list first, then extend the list depending on the platform.