Hi Sowmini, Looking closer at this patchset, I am not sure that a second ACL table is needed. The existing ACL table handles UDP, TCP and SCP, however it is not processing the TCP flags. I think it just needs to be modified to process the TCP flags. Could you take another look to see if the above proposed solution will work for you.
Regards, Bernard. > -----Original Message----- > From: Sowmini Varadhan <sovar...@linux.microsoft.com> > Sent: Thursday, August 19, 2021 4:21 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com> > Cc: sowmin...@gmail.com; dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp > > On (08/19/21 15:06), Iremonger, Bernard wrote: > > > v2 updates: typo fixes for checkpatch, bernard.iremonger comments > > > > The above line should not be added to the commit message. > > ~/dpdk/devtools/check-git-log.sh -1 > > Wrong tag: > > v2 fixes: typo fixes, get_tcp_flags returns -EINVAL > > > > The check-git-log.sh script is in your dpdk checkout, best to run this > > script > before sending patches > > apologies, I was not aware of this, I will fix and send out v3. > I did run check-git-log.sh but before editing the vX updates. > > thanks for your patience. > > --Sowmini
