On Fri, Jun 19, 2015 at 03:04:17PM +0000, Gajdzica, MaciejX T wrote: > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Friday, June 19, 2015 4:48 PM > > To: Gajdzica, MaciejX T > > Cc: dev at dpdk.org; nhorman at tuxdriver.com > > Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros > > > > 2015-06-19 14:38, Gajdzica, MaciejX T: > > > There is an issue with macros in rte_compat.h. For shared library > > > case, macro BIND_DEFAULT_SYMBOL takes three arguments and for other > > > case it takes only two arguments. Also letters for macro variable > > > names are > > not consistent in these two cases. > > > > Yes, and your patch fix it: > > http://dpdk.org/dev/patchwork/patch/5475/ > > But it is part of a series which is not accepted yet. > > > > It would be faster merged if you send it as a standalone patch. > > Thanks > > But simple solution with adding third argument to static library case doesn't > work. Comment in rte_compat.h file describes steps needed to add new version > of the function and it says: > > * 2) rename the existing function int foo(char *string) to > * int __vsym foo_v20(char *string) > * > * 3) Add this macro immediately below the function > * VERSION_SYMBOL(foo, _v20, 2.0); > * > * 4) Implement a new version of foo. > * char foo(int value, int otherval) { ...} > * > * 5) Mark the newest version as the default version > * BIND_DEFAULT_SYMBOL(foo, 2.1); > > So probably BIND_DEFAULT_SYMBOL macro for shared library case needs to be > modified to have two arguments. > I'm not familiar with that symver syntax so I need some help. It would be > better when original author say how it should look like. > > Best Regards > Maciek > >
No adding the third parameter will work just fine. The documentation needs to be updated as well to reflect the 3rd argument: * 5) Mark the newest version as the default version * BIND_DEFAULT_SYMBOL(foo, foo, 2.1); Neil
