30/06/2021 08:34, Xueming Li:
> Current fix scan scripts scanned specified range in HEAD branch.
I cannot parse the above sentence.
> When users ran it in an earlier branch, few patches were scanned
> due to the fixes in the range are newer and not merged to HEAD
> branch.
You mean some patches were not scanned?
>
> This patch introduces optional <branch> argument, default to HEAD
> if not specified. Checks the <range> specified in parameter must
> being merged in <branch>.
Cannot parse either.
> Fixes: 752d8e097ec1 ("scripts: show fixes with release version of bug")
> Cc: Thomas Monjalon <tho...@monjalon.net>
> Cc: sta...@dpdk.org
> Cc: Christian Ehrhardt <christian.ehrha...@canonical.com>
>
> Signed-off-by: Xueming Li <xuemi...@nvidia.com>
[...]
> - echo "usage: $(basename $0) [-h] <git_range>"
> + echo "usage: $(basename $0) [-h] <git_range> [<branch>]"
[...]
> -range="$*"
> +range="$1"
I think it breaks passing range in multiple parameters without quotes.
But it is not really a problem.
> +branch="$2"
> +
> +[ -n "$branch" ] || branch="HEAD"
> +refbranch=$(git rev-parse --abbrev-ref $branch)
Why this line is needed? A comment may help.
If $branch is not used anymore, we can overwrite it
instead of introducing one more variable $refbranch.
> +range_last=$(git log --oneline $range |head -n1|cut -d' ' -f1)
spaces missing around pipes.
You can avoid "head" and "cut" by providing the right options to git.
> +if ! git branch -a --contains $range_last |grep -q -e " $refbranch$" -e "
> remotes/$refbranch$"; then
> + echo "range $range not included by branch $refbranch"
> + exit 1
> +fi
>
> # get major release version of a commit
> commit_version () # <hash>
> {
> local VER="v*.*"
> # use current branch as history reference
> - local refbranch=$(git rev-parse --abbrev-ref HEAD)
You move a line but not its comment above.
