2015-06-18 11:00, Bruce Richardson: > On Wed, Jun 17, 2015 at 11:29:49PM +0200, Thomas Monjalon wrote: > > Introducing rte_cpuflags.h in this header breaks the compilation of > > the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y. > > Indeed, it triggers the -pedantic flag which is not supported by > > rte_cpuflags.h. > > Maybe it's time to fix this header? > > Do all our headers need to support the pedantic C flag? I don't believe this > was a previous requirement for header files. The mlx4 driver appears to be the > only place in the dpdk.org codebase where the flag actually appears - and even > then the flag disabled in mlx.c where the dpdk headers are actually included. > > 73 /* DPDK headers don't like -pedantic. */$ > 74 #ifdef PEDANTIC$ > 75 #pragma GCC diagnostic ignored "-pedantic"$ > 76 #endif$ > 77 #include <rte_config.h>$ > .....
You're right. It seems this disabling doesn't work. > I'm just not convinced that rte_cpuflags needs to be fixed at all here. Yes, it's probably simpler to remove the -pedantic flag.
