https://bugs.dpdk.org/show_bug.cgi?id=775
Bug ID: 775
Summary: Potential error(e.g., resource leak, deadlock) due to
the unreleased lock
Product: DPDK
Version: 20.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: netuio
Assignee: dev@dpdk.org
Reporter: dg573847...@gmail.com
Target Milestone: ---
source:
drivers/net/mlx5/mlx5_txpp.c
Hi, developers, thank you for your checking. The lock sh->txpp.mutex may not be
correctly released if the !sh->txpp.refcnt || --sh->txpp.refcnt is true and
control flow goes to the branch listed below. Finally, the method returns with
the unreleased lock. The fix is to insert
pthread_mutex_unlock(&sh->txpp.mutex); before returning.
void
mlx5_txpp_stop(struct rte_eth_dev *dev)
{
struct mlx5_priv *priv = dev->data->dev_private;
struct mlx5_dev_ctx_shared *sh = priv->sh;
int ret;
if (!priv->txpp_en) {
/* Packet pacing is already disabled for the device. */
return;
}
priv->txpp_en = 0;
ret = pthread_mutex_lock(&sh->txpp.mutex);
MLX5_ASSERT(!ret);
RTE_SET_USED(ret);
MLX5_ASSERT(sh->txpp.refcnt);
if (!sh->txpp.refcnt || --sh->txpp.refcnt)
return; // the method returns with unreleased lock
/* No references any more, do actual destroy. */
mlx5_txpp_destroy(sh);
ret = pthread_mutex_unlock(&sh->txpp.mutex);
MLX5_ASSERT(!ret);
RTE_SET_USED(ret);
}
--
You are receiving this mail because:
You are the assignee for the bug.
