> -----Original Message----- > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > Sent: Wednesday, August 4, 2021 8:28 PM > To: Xueming(Steven) Li <xuemi...@nvidia.com> > Cc: dev@dpdk.org; Ray Kinsella <m...@ashroe.eu> > Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce eth queue release callback > parameter change > > On 8/2/21 4:10 PM, Xueming Li wrote: > > This patch announces the parameter change of eth_queue_release_t > > callback API to eth_dev_ops in DPDK v21.11. > > > > [1] mail list discussion: > > https://mails.dpdk.org/archives/dev/2021-July/215654.html > > > > Signed-off-by: Xueming Li <xuemi...@nvidia.com> > > --- > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index d9c0e65921..c38aebe99d 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -131,6 +131,9 @@ Deprecation Notices > > consistent with existing outer header checksum status flag naming, which > > should help in reducing confusion about its usage. > > > > +* ethdev: queue release callback parameter will be changed to device > > +and queue > > + ID to align with other queue configureation callback. > > + > > * i40e: As there are both i40evf and iavf pmd, the functions of them are > > duplicated. And now more and more advanced features are developed on > > iavf. > > To keep consistent with kernel driver's name > > > > Isn't it an internal callback and no deprecation notice required to change it?
Agree, let's drop this deprecation notice. Thanks for pointing this out. > > "to align with" is a bit weak justification that so huge change is required > (really many sources must be fixed). I guess it could be > required for shared RxQ. If so, it should be mentioned.
