> -----Original Message----- > From: Kinsella, Ray <m...@ashroe.eu> > Sent: Wednesday, August 4, 2021 5:50 PM > To: Xueming(Steven) Li <xuemi...@nvidia.com> > Cc: dev@dpdk.org; Wang Haiyue <haiyue.w...@intel.com>; NBU-Contact-Thomas > Monjalon <tho...@monjalon.net>; Neil Horman > <nhor...@tuxdriver.com> > Subject: Re: [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus > > > > On 25/06/2021 12:47, Xueming Li wrote: > > Auxiliary bus [1] provides a way to split function into child-devices > > representing sub-domains of functionality. Each auxiliary device > > represents a part of its parent functionality. > > > > Auxiliary device is identified by unique device name, sysfs path: > > /sys/bus/auxiliary/devices/<name> > > > > Devargs legacy syntax ofauxiliary device: > > -a auxiliary:<name>[,args...] > > Devargs generic syntax of auxiliary device: > > -a bus=auxiliary,name=<name>,,/class=<classs>,,/driver=<driver>,, > > > > [1] kernel auxiliary bus document: > > https://www.kernel.org/doc/html/latest/driver-api/auxiliary_bus.html > > > > Signed-off-by: Xueming Li <xuemi...@nvidia.com> > > Cc: Wang Haiyue <haiyue.w...@intel.com> > > Cc: Thomas Monjalon <tho...@monjalon.net> > > Cc: Kinsella Ray <m...@ashroe.eu> > > --- > > MAINTAINERS | 5 + > > doc/guides/rel_notes/release_21_08.rst | 6 + > > drivers/bus/auxiliary/auxiliary_common.c | 411 > > ++++++++++++++++++++++ drivers/bus/auxiliary/auxiliary_params.c | 59 ++++ > > drivers/bus/auxiliary/linux/auxiliary.c | 141 ++++++++ > > drivers/bus/auxiliary/meson.build | 16 + > > drivers/bus/auxiliary/private.h | 74 ++++ > > drivers/bus/auxiliary/rte_bus_auxiliary.h | 201 +++++++++++ > > drivers/bus/auxiliary/version.map | 7 + > > drivers/bus/meson.build | 1 + > > 10 files changed, 921 insertions(+) > > create mode 100644 drivers/bus/auxiliary/auxiliary_common.c > > create mode 100644 drivers/bus/auxiliary/auxiliary_params.c > > create mode 100644 drivers/bus/auxiliary/linux/auxiliary.c > > create mode 100644 drivers/bus/auxiliary/meson.build create mode > > 100644 drivers/bus/auxiliary/private.h create mode 100644 > > drivers/bus/auxiliary/rte_bus_auxiliary.h > > create mode 100644 drivers/bus/auxiliary/version.map > > > > [SNIP] > > > diff --git a/drivers/bus/auxiliary/version.map > > b/drivers/bus/auxiliary/version.map > > new file mode 100644 > > index 0000000000..a52260657c > > --- /dev/null > > +++ b/drivers/bus/auxiliary/version.map > > @@ -0,0 +1,7 @@ > > +EXPERIMENTAL { > > + global: > > + > > + # added in 21.08 > > + rte_auxiliary_register; > > + rte_auxiliary_unregister; > > +}; > > Aren't these really internal?
Hi Kinsella, Application might implement driver, so keep it public, same as rte_pci_register. > > > diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build index > > 410058de3a..45eab5233d 100644 > > --- a/drivers/bus/meson.build > > +++ b/drivers/bus/meson.build > > @@ -2,6 +2,7 @@ > > # Copyright(c) 2017 Intel Corporation > > > > drivers = [ > > + 'auxiliary', > > 'dpaa', > > 'fslmc', > > 'ifpga', > >
