On 7/27/21 10:31 AM, Dmitry Kozlyuk wrote:
It was unspecified what happens to indirect actions when a port is stopped, possibly reconfigured, and started again. MLX5 PMD, the first one to use indirect actions, intended to keep them across such a sequence, but the implementation was buggy. Patches 1-3 fix the PMD behavior, patch 4 adds common specification with rationale.
I'm sorry, but it looks very inconsistent. If flow rules are not preserved across restart, indirect actions should not be preserved as well. We need very strong reasons to introduce the inconsistency. If we finally accept it, I think it would be very useful to care about PMDs which cannot preserve it in HW across restart from the very beginning and save it in ethdev layer and restore on start automatically (i.e. do not force all such PMDs to care about the restore internally and basically duplicate the code).
