Re: [dpdk-dev] [PATCH] devtools: test different build types

[Andrew Rybchenko]

On 5/21/21 6:03 PM, David Marchand wrote:

On Mon, Apr 12, 2021 at 11:54 PM Thomas Monjalon <tho...@monjalon.net> wrote:

@@ -213,9 +218,10 @@ for c in gcc clang ; do
                         abicheck=ABI

init of buildtype var is missing here.

+1

Rest lgtm.

                 else
                         abicheck=skipABI # save time and disk space
+                       buildtype='--buildtype=minsize'
                 fi
                 export CC="$CCACHE $c"
-               build build-$c-$s $c $abicheck --default-library=$s
+               build build-$c-$s $c $abicheck $buildtype --default-library=$s
                 unset CC
         done
  done

with review notes applied:

Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>