On 7/13/2021 3:07 PM, Andrew Rybchenko wrote: <...>
> >> diff --git a/drivers/net/e1000/e1000_ethdev.h >> b/drivers/net/e1000/e1000_ethdev.h >> index 3b4d9c3ee6f4..1ae78fe71f02 100644 >> --- a/drivers/net/e1000/e1000_ethdev.h >> +++ b/drivers/net/e1000/e1000_ethdev.h >> @@ -468,8 +468,8 @@ void eth_em_rx_queue_release(void *rxq); >> void em_dev_clear_queues(struct rte_eth_dev *dev); >> void em_dev_free_queues(struct rte_eth_dev *dev); >> >> -uint64_t em_get_rx_port_offloads_capa(struct rte_eth_dev *dev); >> -uint64_t em_get_rx_queue_offloads_capa(struct rte_eth_dev *dev); >> +uint64_t em_get_rx_port_offloads_capa(void); >> +uint64_t em_get_rx_queue_offloads_capa(void); > > I'm not sure that it is a step in right direction. > May be it is better to keep dev unused. > net/e1000 maintainers should decide. > It is possible to keep dev as unused, but these are driver internal functions and 'dev' is not used now, when it is needed it is easy to add it back.
