> -----Original Message-----
> From: Akhil Goyal <gak...@marvell.com>
> Sent: Saturday, July 17, 2021 3:45 AM
> To: Shiri Kuzin <shi...@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <ma...@nvidia.com>; Suanming Mou
> <suanmi...@nvidia.com>; david.march...@redhat.com
> Subject: RE: [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start
> operations
>
> > Add the dev_start function that is used to start a configured device.
> > Add the dev_stop function that is used to stop a configured device.
> >
> > Both functions set the dev parameter as used and return 0.
> >
> > Signed-off-by: Shiri Kuzin <shi...@nvidia.com>
> > Acked-by: Matan Azrad <ma...@nvidia.com>
> > ---
> > drivers/crypto/mlx5/mlx5_crypto.c | 17 +++++++++++++++--
> > 1 file changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/mlx5/mlx5_crypto.c
> > b/drivers/crypto/mlx5/mlx5_crypto.c
> > index ebaa65c7a9..37e66cf57b 100644
> > --- a/drivers/crypto/mlx5/mlx5_crypto.c
> > +++ b/drivers/crypto/mlx5/mlx5_crypto.c
> > @@ -131,6 +131,19 @@ mlx5_crypto_dev_configure(struct rte_cryptodev
> > *dev,
> > return 0;
> > }
> >
> > +static void
> > +mlx5_crypto_dev_stop(struct rte_cryptodev *dev) {
> > + RTE_SET_USED(dev);
> > +}
> > +
> > +static int
> > +mlx5_crypto_dev_start(struct rte_cryptodev *dev) {
> > + RTE_SET_USED(dev);
> > + return 0;
> > +}
> > +
> > static int
> > mlx5_crypto_dev_close(struct rte_cryptodev *dev) { @@ -360,8 +373,8
> > @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t
> > qp_id,
> >
> > static struct rte_cryptodev_ops mlx5_crypto_ops = {
> > .dev_configure = mlx5_crypto_dev_configure,
> > - .dev_start = NULL,
> > - .dev_stop = NULL,
> > + .dev_start = mlx5_crypto_dev_start,
> > + .dev_stop = mlx5_crypto_dev_stop,
> > .dev_close = mlx5_crypto_dev_close,
> > .dev_infos_get = mlx5_crypto_dev_infos_get,
> > .stats_get = NULL,
>
>
> This patch could be squashed in your basic operations patch as these ops are
> not
> doing Anything.
OK, good suggestion.
