> -----Original Message----- > From: Xia, Chenbo <chenbo....@intel.com> > Sent: Friday, July 16, 2021 2:28 PM > To: Hu, Jiayu <jiayu...@intel.com>; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH v4 2/3] vhost: rework async configuration struct > > > > > > -vq->async_inorder = f.async_inorder; async_threshold = > > > > -vq->f.async_threshold; > > > > +vq->async_inorder = true; > > > > > > Do we still need this? It's never used. > > > > I think we need to keep it, as we may support out-of-order channel in > future. > > We don't like to define things when it's not needed currently. If in future, > the > definition should also be made in future :P. Just leave the definition to > future > patch.
Fair. I will delete vq->async_inorder field. Thanks, Jiayu > > Thanks, > Chenbo > > > > > > > > > > +vq->async_threshold = config.async_threshold; > > > > > > vq->async_threshold is uint16_t and config.async_threshold is uint32_t. > > > They should be the same. > > > > I will change vq->async_threshold to uint32_t. > > > > Thanks, > > Jiayu > > > > > > Thanks, > > > Chenbo > > > > > > > > > > > vq->async_registered = true; > > > > > > > > -- > > > > 2.7.4 > > > > > >
