On Thu, Jul 15, 2021 at 10:00:19AM +0200, David Marchand wrote: > Hello, > > On Wed, Jul 14, 2021 at 5:40 AM Zhang, Tianfei <tianfei.zh...@intel.com> > wrote: > > > > > > > > Hi Tianfei, > > > > > > To reproduce this, assume using Ubuntu 20.04. > > > 1. Install libfdt (It will include ifpga driver from > > > drivers/raw/ifpga/base) > > > $ sudo apt-get install libfdt-dev > > > 2. configure DPDK library > > > $ meson build > > > 3. check libdpdk.pc file in build/meson-private/libdpdk.pc. It will > > > include path > > > to librt.so without this patch. > > > > I have checked the libdpdk.pc and got the different between with and > > without this patch. > > Without this patch, there are a full path for librt.so in libdpdk.pc. With > > this patch, it provide "-lrt" in libdpdk.pc. > > > > This patch looks good for me. > > > > Acked-by: Tianfei Zhang <tianfei.zh...@intel.com> > > I can't find the original mail to dev@dpdk.org and patchwork did not help. > Please, can you resubmit this patch? > > Also copy Bruce as this touches a meson subtlety I was not aware of, > and he should probably have a look. > Thanks for flagging this to me, I wasn't aware of the subtlety here at all, but it's good to know for future reference. If asked, I would generally have recommended using find_library without the "lib" prefix on the library name, but I had no idea using with or without leads to different output.
Acked-by: Bruce Richardson <bruce.richard...@intel.com> /Bruce
