[dpdk-dev] [PATCH v3] app/testpmd: fix testpmd doesn't show RSS hash offload

[Jie Wang]

The driver may change offloads info into dev->data->dev_conf
in dev_configure which may cause port->dev_conf and port->rx_conf
contain outdated values.

This patch updates the offloads info if it changes to fix this issue.

Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Cc: sta...@dpdk.org

Signed-off-by: Jie Wang <jie1x.w...@intel.com>
---
v3: 
 - check and update the "offloads" of "port->dev_conf.rx/txmode".
 - update the commit log.
v2: copy "rx/txmode.offloads", instead of copying the entire struct 
"dev->data->dev_conf.rx/txmode". 
---
 app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 1cdd3cdd12..26550340e4 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2475,6 +2475,11 @@ start_port(portid_t pid)
                }
 
                if (port->need_reconfig > 0) {
+                       const struct rte_eth_dev *dev = &rte_eth_devices[pi];
+                       struct rte_eth_conf *dev_conf;
+                       int k;
+
+                       dev_conf = &dev->data->dev_conf;
                        port->need_reconfig = 0;
 
                        if (flow_isolate_all) {
@@ -2508,6 +2513,28 @@ start_port(portid_t pid)
                                port->need_reconfig = 1;
                                return -1;
                        }
+                       /* Apply Rx offloads configuration */
+                       if (dev_conf->rxmode.offloads !=
+                               port->dev_conf.rxmode.offloads) {
+                               port->dev_conf.rxmode.offloads =
+                                       dev_conf->rxmode.offloads;
+                               for (k = 0;
+                                    k < port->dev_info.max_rx_queues;
+                                    k++)
+                                       port->rx_conf[k].offloads =
+                                               dev_conf->rxmode.offloads;
+                       }
+                       /* Apply Tx offloads configuration */
+                       if (dev_conf->txmode.offloads !=
+                               port->dev_conf.txmode.offloads) {
+                               port->dev_conf.txmode.offloads =
+                                       dev_conf->txmode.offloads;
+                               for (k = 0;
+                                    k < port->dev_info.max_tx_queues; 
+                                    k++)
+                                       port->tx_conf[k].offloads =
+                                               dev_conf->txmode.offloads;
+                       }
                }
                if (port->need_reconfig_queues > 0) {
                        port->need_reconfig_queues = 0;
-- 
2.25.1