Thank you for the review, Basically it's not used yet since it will break the abi The main usage was in rte_flow item of gtp_psc To replace the current structure with the header definition. And since this will break the abi I'm adding the header definition now but will be used later in rte_flow.
Kindest regards, Raslan Darawsheh ________________________________ From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> Sent: Thursday, July 8, 2021, 12:23 PM To: Raslan Darawsheh; Singh, Aman Deep; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc Hi Raslan, On 7/6/21 5:24 PM, Raslan Darawsheh wrote: > Hi Guys, > > Sorry for missing this mail, for some reason it was missed in my inbox, > This is the link to this rfc: > https://www.3gpp.org/ftp/Specs/archive/38_series/38.415/38415-g30.zip Thanks for the link. The patch LGTM, but I have only one question left. Where is it used? Are you going to upstream corresponding code in the release cycle? Andrew. > Kindest regards, > Raslan Darawsheh > >> -----Original Message----- >> From: dev <dev-boun...@dpdk.org> On Behalf Of Andrew Rybchenko >> Sent: Thursday, July 1, 2021 5:06 PM >> To: Singh, Aman Deep <aman.deep.si...@intel.com>; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc >> >> Hi Raslan, >> >> could you reply, please. >> >> Andrew. >> >> On 6/22/21 10:27 AM, Singh, Aman Deep wrote: >>> Hi Raslan, >>> >>> Can you please provide link to this RFC 38415-g30 I just had some >>> doubt on byte-order conversion as per RFC 1700 >>> <https://tools.ietf.org/html/rfc1700> >>> >>> Regards >>> Aman