On 7/6/21 12:55 PM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs.
Hopefully final review. $ ./devtools/check-meson.py Error: Incorrect indent at drivers/net/meson.build:43 Error: Incorrect indent at drivers/net/ngbe/meson.build:14 Error: Incorrect indent at drivers/net/ngbe/meson.build:15 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:5 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:6 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:7 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:8 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:9 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:10 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:11 Please, run it after each patch which changes meson.build and fix errors. I'm not sure about __rte_cold markup in the patches. Do you really need it? I'll keep it up to you, but I'd recommend to remove it if you don't really see a measurable performance drop.
