Hi Konstantin/ Olivier, Could you please review this patch? This has also an update in documentation of mbuf.
Regards, Akhil > From: Nithin Dabilpuram <ndabilpu...@marvell.com> > > For Tx inline processing, when RTE_SECURITY_TX_OLOAD_NEED_MDATA is > set, rte_security_set_pkt_metadata() needs to be called for pkts > to associate a Security session with a mbuf before submitting > to Ethdev Tx. This is apart from setting PKT_TX_SEC_OFFLOAD in > mbuf.ol_flags. rte_security_set_pkt_metadata() is also used to > set some opaque metadata in mbuf for PMD's use. > This patch updates documentation that rte_security_set_pkt_metadata() > should be called only with mbuf containing Layer 3 and above data. > This behaviour is consistent with existing PMD's such as ixgbe. > > On Tx, not all net PMD's/HW can parse packet and identify > L2 header and L3 header locations on Tx. This is inline with other > Tx offloads requirements such as L3 checksum, L4 checksum offload, > etc, where mbuf.l2_len, mbuf.l3_len etc, needs to be set for > HW to be able to generate checksum. Since Inline IPSec is also > such a Tx offload, some PMD's at least need mbuf.l2_len to be > valid to find L3 header and perform Outbound IPSec processing. > Hence, this patch updates documentation to enforce setting > mbuf.l2_len while setting PKT_TX_SEC_OFFLOAD in mbuf.ol_flags > for Inline IPSec Crypto / Protocol offload processing to > work on Tx. > > Signed-off-by: Nithin Dabilpuram <ndabilpu...@marvell.com> > Reviewed-by: Akhil Goyal <gak...@marvell.com>
