On Mon, Jul 05, 2021 at 11:09:38AM +0100, Power, Ciara wrote: > > > >-----Original Message----- > >From: Richardson, Bruce <bruce.richard...@intel.com> > >Sent: Friday 2 July 2021 16:23 > >To: dev@dpdk.org > >Cc: Ray Kinsella <m...@ashroe.eu>; Power, Ciara <ciara.po...@intel.com>; > >Richardson, Bruce <bruce.richard...@intel.com> > >Subject: [PATCH 21.11] telemetry: remove experimental tags from APIs > > > >The telemetry APIs have been present and unchanged for >1 year now, so > >remove experimental tag from them. > > > >Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > >--- > > lib/telemetry/rte_telemetry.h | 18 ------------------ > > lib/telemetry/version.map | 2 +- > > 2 files changed, 1 insertion(+), 19 deletions(-) > > > <snip> > > Hi Bruce, > > +1 for this change. > > I think there are some experimental tags missing from this patch - the legacy > telemetry functions that are in "metrics/rte_metrics_telemetry.h" currently > have the tags too.
I'm not sure about making those part of the stable ABI. > Also, there is a reference to the library being experimental in the Telemetry > User Guide doc. > I missed checking the "howto" doc on telemetry, yes. I'll include that in a v2.
