On 7/1/21 10:19 PM, Wiles, Keith wrote: > > >> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger <step...@networkplumber.org> >> wrote: >> >> On Thu, 1 Jul 2021 17:16:21 +0300 >> Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> wrote: >> >>> On 6/16/21 7:15 AM, Stephen Hemminger wrote: >>>> Since these always return 0, they were doing nothing useful. >>>> >>>> Signed-off-by: Stephen Hemminger <step...@networkplumber.org> >>> >>> I have no strong opinion on the patch, but sometimes even >>> empty functions with comments add value. So, I see no point >>> to touch it. So, I'll wait for maintainer reply. >> >> There are always many ways to write more obscure and technically correct >> code. It is best if the code is the smallest correct way. >> >> “I apologize for such a long letter - I didn't have time to write a short >> one.” >> ― Mark Twain > > I agree with Stephen, the extra functions provide no useful feature or even > the comments are not very useful IMO. >
It is a bit different here. You're changing the code in an absolutely equivalent way. IMHO complexity of the code before and after the patch is absolutely the same. Anyway, it does not matter a lot. If it think it would be better in a new way - no problem. @Keith, could you ack the patch series and I'll happily apply it.
