On July 1, 2021 9:57 PM, David Marchand wrote: > Hello, > > Currently looking at new drivers posted on the ml. > > > On Wed, Jun 2, 2021 at 11:40 AM Jiawen Wu <jiawe...@trustnetic.com> > wrote: > > @@ -124,3 +131,12 @@ RTE_PMD_REGISTER_PCI(net_ngbe, > rte_ngbe_pmd); > > RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map); > > RTE_PMD_REGISTER_KMOD_DEP(net_ngbe, "* igb_uio | uio_pci_generic | > > vfio-pci"); > > > > +RTE_LOG_REGISTER(ngbe_logtype_init, pmd.net.ngbe.init, NOTICE); > > +RTE_LOG_REGISTER(ngbe_logtype_driver, pmd.net.ngbe.driver, NOTICE); > > Please use helpers added recently: > https://git.dpdk.org/dpdk/commit/?id=eeded2044af5bbe88220120b14933536c > bb3edb6 > > Converting this patch should be quick: > RTE_LOG_REGISTER_SUFFIX(ngbe_logtype_init, init, NOTICE) > RTE_LOG_REGISTER_SUFFIX(ngbe_logtype_driver, driver, NOTICE); > > etc... > > > + > > +#ifdef RTE_ETHDEV_DEBUG_RX > > + RTE_LOG_REGISTER(ngbe_logtype_rx, pmd.net.ngbe.rx, DEBUG); > > +#endif #ifdef RTE_ETHDEV_DEBUG_TX > > + RTE_LOG_REGISTER(ngbe_logtype_tx, pmd.net.ngbe.tx, DEBUG); > > +#endif > > > > -- > David Marchand
Thanks David, I'd like to convert it in the patch set v6. And are there any comments on other patches?
