On Fri, Jun 25, 2021 at 11:36:21AM +0300, Dmitry Kozlyuk wrote: > 2021-06-24 17:27 (UTC-0700), Narcisa Ana Maria Vasile: > > From: Narcisa Vasile <navas...@microsoft.com> > > > > Fix count_cpu() to ensure it iterates through all the CPUs in a set. > > count_cpu() iterates through the CPUs in the set 's' and counts the > > selected ones. > > > > Previously, it was incorrectly using the number of CPUSETS to iterate > > through the CPUs. > > > > Signed-off-by: Narcisa Vasile <navas...@microsoft.com> > > --- > > lib/eal/windows/include/sched.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Naty, > > Thank you for the fix, but we also need a proper commit message: > > https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > > Specifically, please, describe what was the observable issue (usually first > comes what was wrong, then how it is fixed now) and add "Fixes" tag and Cc. > Also, "number of CPUSETS" sounds unclear, as there's no "CPUSET". > Suggestion: "number of bitset limbs" or maybe if you describe what was > wrong with the result you won't need to describe its reason precisely at all.
Ah, I've mixed some terminology here.. Thank you Dmitry for the feedback!
