Hi Wenfeng It would be better to describe why 'current->pid' cannot, while 'task_pid_vnr(current)' can be used in containers. In addition, the title should be brief, and there should be a commit log for the detailed description.
Thanks, Helin > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenfeng Liu > Sent: Monday, June 1, 2015 1:43 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] kni: Passing virtual PID to get_net_ns_by_pid(), > so > we can create kni interfaces in containers like docker > > Signed-off-by: Wenfeng Liu <liuwf at arraynetworks.com.cn> > --- > lib/librte_eal/linuxapp/kni/kni_misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c > b/lib/librte_eal/linuxapp/kni/kni_misc.c > index 1935d32..18fb677 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_misc.c > +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c > @@ -359,7 +359,7 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long > ioctl_param) > return -EBUSY; > } > > - net = get_net_ns_by_pid(current->pid); > + net = get_net_ns_by_pid(task_pid_vnr(current)); > if (IS_ERR(net)) { > free_netdev(net_dev); > return PTR_ERR(net); > -- > 1.8.3.1
