On Fri, Jun 12, 2015 at 08:46:55AM +0300, Panu Matilainen wrote:
> On 06/12/2015 08:18 AM, Stephen Hemminger wrote:
> >From: Stephen Hemminger <shemming at brocade.com>
> >
> >These were deprecated in 2.0 so remove them from 2.1
> >
> >Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> >---
> > drivers/net/ring/rte_eth_ring.c | 55
> > -------------------------------
> > drivers/net/ring/rte_eth_ring_version.map | 2 --
> > 2 files changed, 57 deletions(-)
> >
> [...]
> >diff --git a/drivers/net/ring/rte_eth_ring_version.map
> >b/drivers/net/ring/rte_eth_ring_version.map
> >index 8ad107d..0875e25 100644
> >--- a/drivers/net/ring/rte_eth_ring_version.map
> >+++ b/drivers/net/ring/rte_eth_ring_version.map
> >@@ -2,8 +2,6 @@ DPDK_2.0 {
> > global:
> >
> > rte_eth_from_rings;
> >- rte_eth_ring_pair_attach;
> >- rte_eth_ring_pair_create;
> >
> > local: *;
> > };
>
> Removing symbols is an ABI break so it additionally requires a soname bump
> for this library.
>
> In addition, simply due to being the first library to do so, it'll also then
> break the combined shared library as is currently is. Mind you, this is not
> an objection at all, the need to change to a linker script approach has
> always been a matter of time.
>
> - Panu -
>
Also, patch title should be prefixed with "ring pmd" or "drivers/net/ring"
rather
than rte_ring, since this is a patch for the ring pmd, not the rte_ring library.
/Bruce
