On 6/2/21 12:40 PM, Jiawen Wu wrote:
This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs.
My main concerns for the patch series except style notes is a separation info patches. Every patch should be testable. I should be able to stop at any patch in the series, do build and test functionality added by the patch. It should be no dead code. Split should be feature based and different features should be added by different patches. Above requirements are not that strict for base driver. Of course, it would be useful to follow it, but not strictly required since sometimes it is very hard to do. As for the PMD specific code, it should be done this way. Otherwise, it is almost impossible to review it and understand if something is lost or missing or inconsistent. Of course, closely related features with share almost all its code may be added together. Initially the driver should be built up to the working state with absolute minimum feature set. No offloads, no extra configuration options. It should be able to probe, configure, start, Rx, Tx, stop, reconfigure, start again etc, close. Subsequent patches should add features one by one: loopback, deferrred start, various offloads, ptype etc.
