> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Saturday, June 12, 2021 4:35 PM
> To: Xueming(Steven) Li <xuemi...@nvidia.com>
> Cc: dev@dpdk.org; Jerin Jacob <jer...@marvell.com>; Sunil Kumar Kori
> <sk...@marvell.com>; Kiran Kumar K
> <kirankum...@marvell.com>; Nithin Dabilpuram <ndabilpu...@marvell.com>;
> david.march...@redhat.com
> Subject: Re: [PATCH] eal: save error in string copy
>
> 12/06/2021 00:49, Xueming Li:
> > From: Thomas Monjalon <tho...@monjalon.net>
> >
> > Sets rte_errrno if the destination buffer is too small.
>
> Would be good to mention the function name, and the reason for the change.
>
> >
> > Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
>
> You did half of the patch, so you should add your Signed-off.
>
> > ---
> > lib/eal/common/eal_common_string_fns.c | 4 +++-
> > lib/eal/common/eal_common_trace.c | 1 -
> > lib/eal/include/rte_string_fns.h | 5 ++---
> > lib/graph/node.c | 12 +++---------
> > 4 files changed, 8 insertions(+), 14 deletions(-)
>
> Did you check all occurences of rte_strcpy?
Yes, looks not too much to modify.
