On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: > On 6/11/21 5:06 AM, Li, Xiaoyun wrote: >> Hi >> -----Original Message----- >> From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> >> Sent: Friday, May 28, 2021 00:25 >> To: Li, Xiaoyun <xiaoyun...@intel.com> >> Cc: dev@dpdk.org >> Subject: [PATCH] app/testpmd: send failure logs to stderr >> >> Running with stdout suppressed or redirected for further processing is very >> confusing in the case of errors. >> >> Signed-off-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> >> --- >> >> This patch looks good to me. >> But what do you think about make it as a fix and backport to stable branches? >> Anyway works for me. > > I have no strong opinion on the topic. > > @Ferruh, what do you think? >
Same here, no strong opinion. Sending errors to 'stderr' looks correct thing to do, but changing behavior in the LTS may cause some unexpected side affect, if it is scripted and testpmd output is parsed etc... For this possibility I would wait for the next LTS. And because of same reason perhaps a release note can be added. Also there is 'TESTPMD_LOG' macro for logs in testpmd, (as well as 'RTE_LOG' macro), I don't know if we should switch all logs, including 'printf', to 'TESTPMD_LOG' macro? Later stdout/sderr can be managed in rte_log level, instead of any specific logic for the testpmd. Even there was a defect for this in the rte_log level, that logs should go to stderr: https://bugs.dpdk.org/show_bug.cgi?id=8 >> Acked-by: Xiaoyun Li <xiaoyun...@intel.com> >
