01/06/2021 05:06, Chenbo Xia: > From: Tiwei Bie <tiwei....@intel.com> > > This patch adds a helper for reading string from sysfs. > > Signed-off-by: Cunming Liang <cunming.li...@intel.com> > Signed-off-by: Tiwei Bie <tiwei....@intel.com> > --- > lib/eal/common/eal_filesystem.h | 10 ++++++++++ > lib/eal/freebsd/eal.c | 22 ++++++++++++++++++++++ > lib/eal/linux/eal.c | 22 ++++++++++++++++++++++ > lib/eal/version.map | 3 +++ > 4 files changed, 57 insertions(+)
3 separate comments: 1/ How much code is portable between Linux and FreeBSD? I guess the path will be different? 2/ Please think about Windows stub. 3/ Instead of EAL, we should start lib/sysfs/ I have other ideas of sysfs functions for PMD use.
