On 4/30/21 7:34 AM, Apeksha Gupta wrote: > This patch supported checksum offloads and add burst enqueue and > dequeue operations to the enetfec PMD. > > Loopback mode is added, compile time flag 'ENETFEC_LOOPBACK' is > used to enable this feature. By default loopback mode is disabled. > Basic features added like promiscuous enable, basic stats.
Please, apply style fixes from the previous patches to the patch as well. > > Signed-off-by: Sachin Saxena <sachin.sax...@nxp.com> > Signed-off-by: Apeksha Gupta <apeksha.gu...@nxp.com> > --- > doc/guides/nics/enetfec.rst | 4 + > doc/guides/nics/features/enetfec.ini | 5 + > drivers/net/enetfec/enet_ethdev.c | 212 +++++++++++- > drivers/net/enetfec/enet_rxtx.c | 499 +++++++++++++++++++++++++++ > 4 files changed, 719 insertions(+), 1 deletion(-) > create mode 100644 drivers/net/enetfec/enet_rxtx.c > > diff --git a/doc/guides/nics/enetfec.rst b/doc/guides/nics/enetfec.rst > index 10f495fb9..adbb52392 100644 > --- a/doc/guides/nics/enetfec.rst > +++ b/doc/guides/nics/enetfec.rst > @@ -75,6 +75,10 @@ ENETFEC driver. > ENETFEC Features > ~~~~~~~~~~~~~~~~~ > > +- Basic stats > +- Promiscuous > +- VLAN offload > +- L3/L4 checksum offload > - ARMv8 > > Supported ENETFEC SoCs > diff --git a/doc/guides/nics/features/enetfec.ini > b/doc/guides/nics/features/enetfec.ini > index 570069798..fcc217773 100644 > --- a/doc/guides/nics/features/enetfec.ini > +++ b/doc/guides/nics/features/enetfec.ini > @@ -4,5 +4,10 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Basic stats = Y > +Promiscuous mode = Y > +VLAN offload = Y > +L3 checksum offload = Y > +L4 checksum offload = Y I don't understand why all above features are in the patch. It looks like all could be added one by one after the patch with adds basic Rx/Tx suppport.
