On Fri, Jun 4, 2021 at 11:40 PM Dmitry Kozlyuk <dmitry.kozl...@gmail.com> wrote: > > I had tried something close when preparing v2 (only keeping > > RTE_HAS_LIBARCHIVE in config/meson.build and putting extra_ldflags and > > ext_deps in lib/eal/unix/meson.build) but both my try and your > > suggestion break static compilation for the helloworld example. > > > > > > $ ./devtools/test-meson-builds.sh -vv > > ... > > ## Building helloworld > [snip] > > Thanks for details. > Indeed, libarchive.pc lists all libraries present at libarchive build time > in Libs.private, despite that libarchive static linkage doesn't require them. > We'll have to go your way, sorry for misdirection. > Maybe it's worth a comment. > > From libarchive README: > > I've attempted to minimize static link pollution. If you don't > explicitly invoke a particular feature (such as support for a > particular compression or format), it won't get pulled in to > statically-linked programs. In particular, if you don't explicitly > enable a particular compression or decompression support, you won't > need to link against the corresponding compression or decompression > libraries. This also reduces the size of statically-linked binaries > in environments where that matters.
Yes, I can explain this in v3, but I'll wait a bit to see if issues with this series are discovered. Thanks Dmitry. -- David Marchand
