> -----Original Message-----
> From: Thierry Herbelot <thierry.herbe...@6wind.com>
> Sent: Monday, May 24, 2021 2:29 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbe...@6wind.com>; Thomas Monjalon
> <tho...@monjalon.net>; sta...@dpdk.org; Gagandeep Singh
> <g.si...@nxp.com>
> Subject: [PATCH] net/pfe: do not use a possibly NULL Pointer
>
> Use dev only after it was checked not to be NULL.
>
> Fixes: acd4818ea2a45 ("net/pfe: add link status update")
> Cc: sta...@dpdk.org
> Cc: Gagandeep Singh <g.si...@nxp.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbe...@6wind.com>
> ---
> drivers/net/pfe/pfe_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c
> index 3135466713fb..09048e57d973 100644
> --- a/drivers/net/pfe/pfe_ethdev.c
> +++ b/drivers/net/pfe/pfe_ethdev.c
> @@ -578,7 +578,7 @@ static int
> pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete
> __rte_unused)
> {
> int ret, ioctl_cmd = 0;
> - struct pfe_eth_priv_s *priv = dev->data->dev_private;
> + struct pfe_eth_priv_s *priv;
> struct rte_eth_link link, old;
> unsigned int lstatus = 1;
>
> @@ -586,6 +586,7 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int
> wait_to_complete __rte_unused)
> PFE_PMD_ERR("Invalid device in link_update.\n");
> return 0;
> }
> + priv = dev->data->dev_private;
"dev" will never be NULL here because librte_ethdev library is already doing
some checks on dev before calling the link update. So please remove the if
check.
>
> memset(&old, 0, sizeof(old));
> memset(&link, 0, sizeof(struct rte_eth_link));
> --
> 2.29.2
