From: Ferruh Yigit <ferruh.yi...@intel.com>
%lx or %llx tend to be wrong for 32-bit platform
if used for fixed size variable like uint64_t.
A checkpatch warning will avoid this common mistake.
Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
---
v3: more explicit message
v2: proposal to reword the message and comment
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ba43f84e64..c30dadd962 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -69,6 +69,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # check %l or %ll format specifier
+ awk -v FOLDERS='lib drivers app examples' \
+ -v EXPRESSIONS='%ll*[xud]' \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Using %l format, prefer %PRI*64 if type is
[u]int64_t' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# forbid variable declaration inside "for" loop
awk -v FOLDERS='.' \
-v
EXPRESSIONS='for[[:space:]]*\\((char|u?int|unsigned|s?size_t)' \
--
2.31.1
