> -----Original Message----- > From: Wan Junjie <wanjun...@bytedance.com> > Sent: Thursday, May 13, 2021 6:52 PM > To: Xia, Chenbo <chenbo....@intel.com> > Cc: David Marchand <david.march...@redhat.com>; Maxime Coquelin > <maxime.coque...@redhat.com>; dev@dpdk.org; Peng He > <hepeng.0...@bytedance.com>; Zhihong Wang <wangzhihong....@bytedance.com>; > Thomas Monjalon <tho...@monjalon.net> > Subject: Re: [External] RE: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool > allocation while IOMMU disabled > > On Thu, May 13, 2021 at 6:24 PM Xia, Chenbo <chenbo....@intel.com> wrote: > > > > > -----Original Message----- > > > From: David Marchand <david.march...@redhat.com> > > > Sent: Thursday, May 13, 2021 4:39 PM > > > To: Xia, Chenbo <chenbo....@intel.com>; Maxime Coquelin > > > <maxime.coque...@redhat.com> > > > Cc: Wan Junjie <wanjun...@bytedance.com>; dev@dpdk.org; Peng He > > > <hepeng.0...@bytedance.com>; Zhihong Wang <wangzhihong....@bytedance.com> > > > Subject: Re: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation > while > > > IOMMU disabled > > > > > > On Wed, Apr 7, 2021 at 9:10 AM Xia, Chenbo <chenbo....@intel.com> wrote: > > > > > > > > > -----Original Message----- > > > > > From: Wan Junjie <wanjun...@bytedance.com> > > > > > Sent: Tuesday, February 2, 2021 4:15 PM > > > > > To: Xia, Chenbo <chenbo....@intel.com>; Maxime Coquelin > > > > > <maxime.coque...@redhat.com> > > > > > Cc: dev@dpdk.org; Wan Junjie <wanjun...@bytedance.com>; Peng He > > > > > <hepeng.0...@bytedance.com>; Zhihong Wang > <wangzhihong....@bytedance.com> > > > > > Subject: [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU > > > disabled > > > > > > > > > > If vhost device's IOMMU feature is disabled, iotlb mempool allocation > > > > > is unnecessary. > > > > > > > > > > Reported-by: Peng He <hepeng.0...@bytedance.com> > > > > > Signed-off-by: Wan Junjie <wanjun...@bytedance.com> > > > > > Reviewed-by: Zhihong Wang <wangzhihong....@bytedance.com> > > > > > --- > > > > > 2.11.0 > > > > > > > > Patch applied to next-virtio/main with conflict resolved, Thanks > > > > > > This patch triggered a regression reported by Red Hat QE. > > > https://bugs.dpdk.org/show_bug.cgi?id=703 > > > > > > > > Reverting the patch is enough to fix the regression. > > > > > > I'll let you guys decide on the next step for 21.05. > > > > > > > > > -- > > > David Marchand > > > > I cannot reproduce this issue on my machine. > > > > @Wan Junjie Could you reproduce this? I prefer to revert the patch if things > > are not very clear as it is only a minor optimization. > > > > Thanks, > > Chenbo > > > > > > Hi Chenbo, > > I am not available for this now. Please revert it. > Will dig it later. > > Thanks, > Junjie
Luckily I can reproduce now. I will take a look. Chenbo
