2021-05-11 09:41 (UTC+0200), Thomas Monjalon:
> 02/05/2021 04:33, Dmitry Kozlyuk:
> > Interrupt manager in Windows EAL allocates on IOCP and starts
> > a control thread that runs indefinitely. At DPDK cleanup
> > this thread was not stopped and IOCP handle was not closed.
> >
> > Gracefully stop interrupt-handling in rte_eal_cleanup().
> > The thread already closes IOCP handle before exiting.
> >
> > Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>
> > ---
> > lib/eal/windows/eal.c | 1 +
> > lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++--
> > lib/eal/windows/eal_windows.h | 5 +++++
> > 3 files changed, 30 insertions(+), 2 deletions(-)
>
> It seems nobody reviewed.
> To be on the safe side, I'll merge this series after DPDK 21.05 is released.
> Or am I missing any critical issue?
IIRC Windows DPDK is not shipped anywhere yet, so the fix can be postponed.
Without fix in 2/3 rte_eal_alarm_set() will start failing after some
thousands of calls (i40e calls every 50 ms, mlx5 call every 1 sec or less).
For mlx5 it seems to break flow counters (mlx5_flow_query_alarm function).
