2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: [...] > diff --git a/lib/librte_eal/include/rte_thread_types.h > b/lib/librte_eal/include/rte_thread_types.h > index a884daf17..37bc7af2b 100644 > --- a/lib/librte_eal/include/rte_thread_types.h > +++ b/lib/librte_eal/include/rte_thread_types.h > @@ -7,9 +7,12 @@ > > #include <pthread.h> > > +#define RTE_THREAD_MUTEX_INITIALIZER PTHREAD_MUTEX_INITIALIZER > +
I'd wrap this in #ifndef RTE_EXEC_ENV_WINDOWS, so that portable code couldn't accidentally rely on it. > #define EAL_THREAD_PRIORITY_NORMAL 0 > #define EAL_THREAD_PRIORITY_REALTIME_CIRTICAL 99 > > typedef pthread_t rte_thread_t; > +typedef pthread_mutex_t rte_thread_mutex_t; > > #endif /* _RTE_THREAD_TYPES_H_ */ > diff --git a/lib/librte_eal/windows/include/rte_windows_thread_types.h > b/lib/librte_eal/windows/include/rte_windows_thread_types.h > index 8cb4b3856..47c6b2664 100644 > --- a/lib/librte_eal/windows/include/rte_windows_thread_types.h > +++ b/lib/librte_eal/windows/include/rte_windows_thread_types.h > @@ -11,5 +11,6 @@ > #define EAL_THREAD_PRIORITY_REALTIME_CIRTICAL THREAD_PRIORITY_TIME_CRITICAL > > typedef DWORD rte_thread_t; > +typedef CRITICAL_SECTION rte_thread_mutex_t; > > #endif /* _RTE_THREAD_TYPES_H_ */ You have to ensure that sizeof(rte_thread_mutex_t) is the same with both backends. MinGW's winpthread has "typedef void *pthread_mutex_t", while CRITICAL_SECTION is much larger. If you decide to make rte_thread_mutext_t a pointer on Windows, consider implementing RTE_THREAD_MUTEX_INITILIZER.
