Hi, > -----Original Message----- > From: Yigit, Ferruh <[email protected]> > Sent: Thursday, April 22, 2021 00:21 > To: Igor Russkikh <[email protected]>; Pavel Belous > <[email protected]>; Somalapuram Amaranath > <[email protected]>; Ajit Khaparde <[email protected]>; > Somnath Kotur <[email protected]>; Hemant Agrawal > <[email protected]>; Sachin Saxena > <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue > <[email protected]>; Daley, John <[email protected]>; Hyong Youb > Kim <[email protected]>; Min Hu (Connor) <[email protected]>; > Yisen Zhuang <[email protected]>; Lijun Ou > <[email protected]>; Xing, Beilei <[email protected]>; Yang, Qiming > <[email protected]>; Zhang, Qi Z <[email protected]>; Andrew > Boyer <[email protected]>; Jerin Jacob <[email protected]>; Nithin > Dabilpuram <[email protected]>; Kiran Kumar K > <[email protected]>; Rasesh Mody <[email protected]>; > Devendra Singh Rawat <[email protected]>; Andrew Rybchenko > <[email protected]>; Jiawen Wu > <[email protected]>; Jian Wang <[email protected]>; > Thomas Monjalon <[email protected]>; Selwin Sebastian > <[email protected]>; Remy Horton <[email protected]>; > Chunsong Feng <[email protected]>; Huisong Li > <[email protected]>; Hao Chen <[email protected]>; Wei Hu > (Xavier) <[email protected]>; Wu, Jingjing > <[email protected]>; Lu, Wenzhuo <[email protected]>; Li, > Xiaoyun <[email protected]>; Zhang, AlvinX <[email protected]>; > Shannon Nelson <[email protected]>; Alfredo Cardigliano > <[email protected]>; Vamsi Attunuru <[email protected]>; Yash > Sharma <[email protected]>; Ivan Malov <[email protected]>; > Andrew Lee <[email protected]> > Cc: Yigit, Ferruh <[email protected]>; [email protected]; [email protected] > Subject: [PATCH] drivers/net: fix FW version get > > Fixes a few different things: > * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is > zero, 'fw_version' being NULL but 'fw_size' not zero condition checked > in ethdev layer > * Be sure required buffer size is returned if provided one is not big > enough, instead of returning success (0) > * Document in doxygen comment the '-EINVAL' is a valid return type > * Take into account that 'snprintf' can return negative value > * Cast length to 'size_t' to compare it with 'fw_size' > > Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop") > Fixes: ff70acdf4299 ("net/axgbe: support reading FW version") > Fixes: e2652b0a20a0 ("net/bnxt: support get FW version") > Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API") > Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version get") > Fixes: b883c0644a24 ("net/e1000: add firmware version get") > Fixes: 293430677e9c ("net/enic: add handler to return firmware version") > Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") > Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version") > Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get") > Fixes: e31cb9a36298 ("net/ice: support FW version getting") > Fixes: 4f09bc55ac3d ("net/igc: implement device base operations") > Fixes: eec10fb0ce6b ("net/ionic: support FW version") > Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") > Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation") > Fixes: f97b56f9f12e ("net/qede: support FW version query") > Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version") > Fixes: bc84ac0fadef ("net/txgbe: support getting FW version") > Fixes: 21913471202f ("ethdev: add firmware version get") > Cc: [email protected] > > Signed-off-by: Ferruh Yigit <[email protected]> > --- > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > drivers/net/atlantic/atl_ethdev.c | 7 ++++--- > drivers/net/axgbe/axgbe_rxtx.c | 4 ---- > drivers/net/bnxt/bnxt_ethdev.c | 4 +++- > drivers/net/dpaa/dpaa_ethdev.c | 6 ++++-- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++- > drivers/net/e1000/igb_ethdev.c | 4 +++- > drivers/net/enic/enic_ethdev.c | 15 ++++++++++----- > drivers/net/hns3/hns3_ethdev.c | 5 ++++- > drivers/net/hns3/hns3_ethdev_vf.c | 5 ++++- > drivers/net/i40e/i40e_ethdev.c | 4 +++- > drivers/net/ice/ice_ethdev.c | 4 +++- > drivers/net/igc/igc_ethdev.c | 4 +++- > drivers/net/ionic/ionic_ethdev.c | 15 +++++++++------ > drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++- > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > drivers/net/qede/qede_ethdev.c | 3 --- > drivers/net/sfc/sfc_ethdev.c | 8 -------- > drivers/net/txgbe/txgbe_ethdev.c | 4 +++- > lib/librte_ethdev/rte_ethdev.h | 1 + > 19 files changed, 61 insertions(+), 42 deletions(-) >
For ice driver, Acked-by: Qiming Yang <[email protected]>
