From: Chengchang Tang <tangchengch...@huawei.com>
The variable type of the current socket ID is uint8_t. When traversing all
nodes, the socket ID is compared with RTE_MAX_NUMA_NODES. Since
RTE_MAX_NUMA_NODES has not been verified, it may be larger than UCHAR_MAX
theoretically. This would lead to an infinite loop.
This patch declares the socket ID type as 'int' or 'unsigned int' by
referring to the common practice in EAL.
Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Fixes: f00708c2aa53 ("node: add IPv4 rewrite and lookup control")
Cc: sta...@dpdk.org
Signed-off-by: Chengchang Tang <tangchengch...@huawei.com>
Signed-off-by: Min Hu (Connor) <humi...@huawei.com>
---
lib/efd/rte_efd.c | 4 ++--
lib/node/ip4_lookup.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c
index 77f4680..4d354d8 100644
--- a/lib/efd/rte_efd.c
+++ b/lib/efd/rte_efd.c
@@ -500,7 +500,7 @@ rte_efd_create(const char *name, uint32_t max_num_rules,
uint32_t key_len,
struct rte_efd_table *table = NULL;
uint8_t *key_array = NULL;
uint32_t num_chunks, num_chunks_shift;
- uint8_t socket_id;
+ unsigned int socket_id;
struct rte_efd_list *efd_list = NULL;
struct rte_tailq_entry *te;
uint64_t offline_table_size;
@@ -746,7 +746,7 @@ rte_efd_find_existing(const char *name)
void
rte_efd_free(struct rte_efd_table *table)
{
- uint8_t socket_id;
+ unsigned int socket_id;
struct rte_efd_list *efd_list;
struct rte_tailq_entry *te, *temp;
diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index d083a72..4811378 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -129,7 +129,7 @@ rte_node_ip4_route_add(uint32_t ip, uint8_t depth, uint16_t
next_hop,
{
char abuf[INET6_ADDRSTRLEN];
struct in_addr in;
- uint8_t socket;
+ int socket;
uint32_t val;
int ret;
--
2.7.4
