2015-06-05 17:01, Bruce Richardson: > The macro to turn on additional debug output when the app was compiled > with "-DDEBUG" was missing a ";".
It shows that such dead code is almost never tested. It would be saner if this command would return no result: git grep 'ifdef.*DEBUG' examples examples/distributor/main.c:#ifdef DEBUG examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG examples/packet_ordering/main.c:#ifdef DEBUG examples/vhost/main.c:#ifdef DEBUG examples/vhost/main.h:#ifdef DEBUG examples/vhost_xen/main.c:#ifdef DEBUG examples/vhost_xen/main.h:#ifdef DEBUG There is no good reason to not use CONFIG_RTE_LOG_LEVEL to trigger debug build.