clang 12 gives a warning about string concatenation in arrays.
In this case, as it is a long string test the strings are concatenated.
Add parentheses to indicate this.

$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)

[2556/2719]
Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o
../app/test/test_cmdline_num.c:204:5: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"1111000011110000111100001111000011110000111100001111000011110000",
^
../app/test/test_cmdline_num.c:203:3: note:
place parentheses around the string literal to silence warning
"0b1111000011110000111100001111000011110000111100001111000011110000"
^

Signed-off-by: Kevin Traynor <ktray...@redhat.com>

---
v2: updated commit msg
---
 app/test/test_cmdline_num.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c
index ec479cdb3a..9276de59bd 100644
--- a/app/test/test_cmdline_num.c
+++ b/app/test/test_cmdline_num.c
@@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
                "-0b0111010101",
                /* too long (128+ chars) */
-               
"0b1111000011110000111100001111000011110000111100001111000011110000"
-                 
"1111000011110000111100001111000011110000111100001111000011110000",
+               
("0b1111000011110000111100001111000011110000111100001111000011110000"
+                 
"1111000011110000111100001111000011110000111100001111000011110000"),
                "1E3",
                "0A",
-- 
2.30.2

Reply via email to