13/04/2021 03:12, Min Hu (Connor): > 在 2021/4/12 15:19, David Marchand 写道: > > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) <humi...@huawei.com> wrote: > >> > >> This set of patches support set thread name for debugging. > >> > >> Chengwen Feng (7): > >> net/ark: support set thread name > >> net/ice: support set VSI reset thread name > >> vdpa/ifc: support set notify and vring relay thread name > >> raw/ifpga: support set monitor thread name > >> examples/performance-thread: support set thread name > >> telemetry: support set init threads name > >> examples/vhost_blk: support set ctrl worker thread name > > > > Rather than add those calls, can maintainers check if their component > > can use ctrl threads instead? > > rte_ctrl_thread_create ensures both that the name is set, and that the > > ctrl thread won't run on the same cpu as "datapath" threads. > > > > I also saw some issues with components creating threads. > > I'll post a series addressing those later (net/ark, net/ice not > > detaching/joining created threads + telemetry not checking > > pthread_create failures). > > > Totally agree with David. > By the way, for "telemetry not checking pthread_create failures", I have > sent patches to fix it. Please check it out. > Thanks.
Do I understand correctly that we prefer switching to rte_ctrl_thread_create() instead of this patch series adding rte_thread_setname()? Any volunteer to add the use of rte_ctrl_thread_create() in these drivers and examples?
