> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Wednesday, April 14, 2021 2:16 PM > To: McDaniel, Timothy <timothy.mcdan...@intel.com> > Cc: dpdk-dev <dev@dpdk.org>; Carrillo, Erik G <erik.g.carri...@intel.com>; > Gage > Eads <gage.e...@intel.com>; Van Haaren, Harry > <harry.van.haa...@intel.com>; Jerin Jacob <jer...@marvell.com>; Thomas > Monjalon <tho...@monjalon.net> > Subject: Re: [dpdk-dev] [PATCH v3 01/26] event/dlb2: add v2.5 probe > > On Wed, Apr 14, 2021 at 1:46 AM Timothy McDaniel > <timothy.mcdan...@intel.com> wrote: > > > > This commit adds dlb v2.5 probe support, and updates > > parameter parsing. > > > > The dlb v2.5 device differs from dlb v2, in that the > > number of resources (ports, queues, ...) is different, > > so macros have been added to take the device version > > into account. > > > > Please move the original source cleanup (the below items) to separate patch > > > This commit also cleans up a few issues in the original > > dlb2 source: > > - eliminate duplicate constant definitions > > - removed unused constant definitions > > - remove #ifdef FPGA > > - remove unused include file, dlb2_mbox.h
All in all it was quite minor, but I'll try to do this if you think its necessary. Thanks, Tim
