09/04/2021 14:25, Thomas Monjalon: > From: Gabriel Ganne <gabriel.ga...@6wind.com> > > The pcap PMD and the librte_port both declare their dependency to libpcap > with a line "ext_deps += pcap_dep". > Then meson automatically adds this dependency to the pkg-config file > in the "Requires.private" section for static builds. > > The additional update of dpdk_extra_ldflags was adding the dependency > in the "Libs.private" section of the pkg-config, that is unnecessary. > > Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson") > Fixes: 268fa581b1ff ("port: fix pcap support with meson") > Cc: sta...@dpdk.org > > Signed-off-by: Gabriel Ganne <gabriel.ga...@6wind.com> > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > --- > I have a doubt whether this option is really always useless. > In the case of an old pcap (<1.9) without pkg-config support, > and with the minimum meson supported (0.47.1), > are we sure the generated pkg-config file will include -lpcap?
Any volunteer to test please?