HI Thomas,
#1, okay , will modify title as " ethdev: dump single flow rule " .
#2, yes, it can pass NULL. Will modify as you described.
Thank you so much for the comments.
-----Original Message-----
From: Thomas Monjalon <tho...@monjalon.net>
Sent: Wednesday, April 14, 2021 4:58 PM
To: Haifei Luo <haif...@nvidia.com>
Cc: dev@dpdk.org; Ori Kam <or...@nvidia.com>; Slava Ovsiienko
<viachesl...@nvidia.com>; Raslan Darawsheh <rasl...@nvidia.com>;
Xueming(Steven) Li <xuemi...@nvidia.com>; Haifei Luo <haif...@nvidia.com>;
ajit.khapa...@broadcom.com; Xiaoyun Li <xiaoyun...@intel.com>; Matan Azrad
<ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>; Jerin Jacob
<jer...@marvell.com>; Nithin Dabilpuram <ndabilpu...@marvell.com>; Kiran Kumar
K <kirankum...@marvell.com>; Ferruh Yigit <ferruh.yi...@intel.com>; Andrew
Rybchenko <andrew.rybche...@oktetlabs.ru>
Subject: Re: [PATCH v4 1/3] ethdev: modify rte API for single flow dump
External email: Use caution opening links or attachments
About the title, what is "rte API"?
I guess you mean DPDK API with rte prefix.
But given all DPDK API have rte prefix,
and this patch is for DPDK,
you can just say "API".
So the title can be:
ethdev: modify API for single flow dump
But it can look as single flow dump was possible before, which is wrong because
it is a new feature.
Another idea is wrong:
The packets of the flow are not dumped,
it is only dumping the HW representation of the flow rule.
I propose to simply describe the new feature:
ethdev: dump single flow rule
> + * @param[in] flow
> + * The pointer of rte flow.
Please replace "rte flow" with 'flow rule".
Is it allowed to pass NULL? Will it dump all?
If yes, you can change to:
Flow rule to dump.
Dump all rules if NULL.
