On 4/14/2021 7:13 AM, Haifei Luo wrote:
Add "Flow dump" in features/default.ini and features/mlx5.ini.
Add testpmd CLI and API changes in release_notes.

Signed-off-by: Haifei Luo <haif...@nvidia.com>
---
  doc/guides/nics/features/default.ini   | 1 +
  doc/guides/nics/features/mlx5.ini      | 1 +
  doc/guides/rel_notes/release_21_05.rst | 5 +++++
  3 files changed, 7 insertions(+)

diff --git a/doc/guides/nics/features/default.ini 
b/doc/guides/nics/features/default.ini
index 8046bd1..49aaf17 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -39,6 +39,7 @@ DCB                  =
  VLAN filter          =
  Flow control         =
  Flow API             =
+Flow dump            =

Hi Haifei,

I don't think "flow dump" is important enough to be listed in the feature list, I am for not adding it. Comparing the one line above item, "Flow API", this one is small and indeed subset of it.

  Rate limitation      =
  Traffic mirroring    =
  Inline crypto        =
diff --git a/doc/guides/nics/features/mlx5.ini 
b/doc/guides/nics/features/mlx5.ini
index ddd131d..3c5fcff 100644
--- a/doc/guides/nics/features/mlx5.ini
+++ b/doc/guides/nics/features/mlx5.ini
@@ -29,6 +29,7 @@ SR-IOV               = Y
  VLAN filter          = Y
  Flow control         = Y
  Flow API             = Y
+Flow dump            = Y
  CRC offload          = Y
  VLAN offload         = Y
  L3 checksum offload  = Y
diff --git a/doc/guides/rel_notes/release_21_05.rst 
b/doc/guides/rel_notes/release_21_05.rst
index a0b9079..e3ae470 100644
--- a/doc/guides/rel_notes/release_21_05.rst
+++ b/doc/guides/rel_notes/release_21_05.rst
@@ -174,6 +174,8 @@ New Features
      ``dpdk-testpmd -- --eth-link-speed N``
    * Added command to display Rx queue used descriptor count.
      ``show port (port_id) rxq (queue_id) desc used count``
+  * Added command to dump internal representation information of single flow.
+    ``flow dump (port_id) rule (rule_id)``
Removed Items
@@ -207,6 +209,9 @@ API Changes
     Also, make sure to start the actual text at the margin.
     =======================================================
+* ethdev: Added a rte_flow pointer parameter to the function
+  ``rte_flow_dev_dump()`` allowing dump for single flow.
+
  * eal: The experimental TLS API added in ``rte_thread.h`` has been renamed
    from ``rte_thread_tls_*`` to ``rte_thread_*`` to avoid naming redundancy
    and confusion with the transport layer security term.


Can you please distribute the release notes updates to the patches that introduces the change? So there should be a separate release notes update patch.

Thanks.

Reply via email to