Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, June 04, 2015 10:27 AM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups
>
> Hi Konstantin,
>
> 2015-06-04 00:10, Konstantin Ananyev:
> > This patch-set is based on:
> > [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for
> > it to the UT.
> >
> > Konstantin Ananyev (8):
> > ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK
> > ACL: code cleanup - use global RTE_LEN2MASK macro
> > ACL: add function to check rte_acl_build() input parameters
> > ACL: fix rebuilding a trie for subset of rules
> > ACL: introduce RTE_ACL_MASKLEN_TO_BITMASK macro
> > ACL: cleanup remove unused code from acl_bld.c
> > ACL: fix remove ambiguity between rules at UT
> > ACL: add new test-cases into UT
>
> Commit titles would be more useful if they shortly explain the goal instead
> of giving some function/macro names. It should be thought as a changelog entry
> and reflect behavioral change.
There is no changes in behaviour.
Just fixes and clean-ups.
> On a side note, the keyword ACL: should be lowercase.
>
> In the case of fixes, adding a Fixes: line may help.
> It can be generated with this command:
> git log -1 --abbrev=12 --format='Fixes: %h ("%s")' <commit>
Ok, will update commit messages in v2.
Konstantin
>
> Thanks
