2021-04-08 13:45 (UTC+0200), Olivier Matz: [...] > > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c > > index c572d003cb..e7361bf520 100644 > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -22,6 +22,7 @@ > > #include <rte_sctp.h> > > #include <rte_hash_crc.h> > > #include <rte_bitmap.h> > > +#include <rte_os_shim.h> > > > > If I understand the logic, rte_ip.h provides OS-specific IP-related > stuff (like IPPROTO_*), and rte_os_shim.h provides the POSIX definitions > that are missing after including rte_ip.h. > > Would it make sense to include rte_os_shim.h from rte_ip.h, so that > including rte_ip.h is always sufficient? Or is it because we want to > avoid implicit inclusion of rte_os_shim.h?
Yes, currently rte_os_shim.h is not exposed at all. It it ever will, this reason still applies.
