06/04/2021 19:59, David Marchand: > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: Existing version.map annotation achieved with: > $ for dir in lib/librte_eal drivers/common/mlx5; do > ./buildtools/map-list-symbol.sh $dir/*.map | > while read file version sym; do > ! git grep -qw $sym $dir/*.def || continue; > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map; > done; > done > > Signed-off-by: David Marchand <david.march...@redhat.com>
Acked-by: Thomas Monjalon <tho...@monjalon.net> That's a nice improvement. Fixes to remove WINDOWS_NO_EXPORT annotations would be great to see from the original authors of the concerned symbols. I think we should merge this patch quickly to avoid having more discrepancies with the coming EAL patches.
