22/03/2021 11:33, David Marchand: > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > > index 6a1b44bc77..bf7afe4610 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -25,7 +25,7 @@ > > > > #include "base/ifcvf.h" > > > > -RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.net.ifcvf_vdpa, NOTICE); > > +RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > > The driver is in drivers/vdpa/ifc, I would expect pmd.vdpa.ifc
I'm not sure for this one. My understanding is that the name of the driver can be a little different of the directory name, especially if having multiple drivers in a directory. Here there is only VF in IFC. > We have some little variations for the af_packet and bonding drivers, > worth aligning from my pov. > drivers/net/af_packet/rte_eth_af_packet.c:RTE_LOG_REGISTER(af_packet_logtype, > pmd.net.packet, NOTICE); > drivers/net/bonding/rte_eth_bond_pmd.c:RTE_LOG_REGISTER(bond_logtype, > pmd.net.bond, NOTICE); Yes good catch, will align these two. > And ipn3ke is odd too: > drivers/net/ipn3ke/ipn3ke_ethdev.c:RTE_LOG_REGISTER(ipn3ke_afu_logtype, > pmd.afu.ipn3ke, NOTICE); I agree it's strange, but I don't understand ifpga and ipn3ke enough to have a good judgement. I feel more naming have to be carified in this driver. I will highlight ifc and ipn3ke in v2 to have a conclusion. Rosen, Xiao, please comment.
