On 4/1/2021 5:05 PM, Keiichi Watanabe wrote:
Thanks for the review!
Should I send the updated version of the patch series? Or, can I ask you to make
the follow up changes as a maintainer?
No new version is required, already updated in the next-net [1] repo.
[1] https://git.dpdk.org/next/dpdk-next-net/
Keiichi
On Thu, Apr 1, 2021 at 5:42 PM Kinsella, Ray <m...@ashroe.eu
<mailto:m...@ashroe.eu>> wrote:
On 31/03/2021 17:45, Ferruh Yigit wrote:
> On 3/22/2021 7:22 AM, Keiichi Watanabe wrote:
>> Add rte_vhost_get_negotiated_protocol_features, which returns a set of
>> enabled protocol features.
>>
>> Signed-off-by: Keiichi Watanabe <keiic...@chromium.org
<mailto:keiic...@chromium.org>>
>
> <...>
>
>> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map
>> index 9183d6f2f..95c4c0990 100644
>> --- a/lib/librte_vhost/version.map
>> +++ b/lib/librte_vhost/version.map
>> @@ -63,6 +63,7 @@ EXPERIMENTAL {
>> rte_vhost_va_from_guest_pa;
>> rte_vhost_extern_callback_register;
>> rte_vhost_driver_set_protocol_features;
>> + rte_vhost_get_negotiated_protocol_features;
>> rte_vhost_set_inflight_desc_split;
>> rte_vhost_set_inflight_desc_packed;
>> rte_vhost_set_last_inflight_io_split;
>
> Added the release version that experimental API is added as comment in
next-net, like following:
>
> +++ b/lib/librte_vhost/version.map
> @@ -76,4 +76,7 @@ EXPERIMENTAL {
> rte_vhost_async_channel_unregister;
> rte_vhost_submit_enqueue_burst;
> rte_vhost_poll_enqueue_completed;
> +
> + # added in 21.05
> + rte_vhost_get_negotiated_protocol_features;
> };
>
>
> We are doing this already in many libraries [1], this helps us easily
observe how long an API is staying as experimental in a library.
Good idea.
> [1]:
https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407
<https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407>
